 1f0b797ddc
			
		
	
	
		1f0b797ddc
		
			
		
	
	
	
	
		
			
			Reduce the code duplication in the PushCreate test and switch to a declarative format. * Instead of explicitly creating the repository re-use functions from the other declarative tests and add comments * Ensure that the test repository is deleted at the end of test * Slightly reorder the sub-tests Also reduce the code duplication in MergeFork and add some comments there too and make doGitCloneFail be self-contained. Signed-off-by: Andrew Thornton art27@cantab.net
		
			
				
	
	
		
			214 lines
		
	
	
	
		
			6.6 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			214 lines
		
	
	
	
		
			6.6 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // Copyright 2019 The Gitea Authors. All rights reserved.
 | |
| // Use of this source code is governed by a MIT-style
 | |
| // license that can be found in the LICENSE file.
 | |
| 
 | |
| package integrations
 | |
| 
 | |
| import (
 | |
| 	"fmt"
 | |
| 	"io/ioutil"
 | |
| 	"net/http"
 | |
| 	"net/url"
 | |
| 	"os"
 | |
| 	"path/filepath"
 | |
| 	"testing"
 | |
| 	"time"
 | |
| 
 | |
| 	"code.gitea.io/gitea/modules/git"
 | |
| 	api "code.gitea.io/gitea/modules/structs"
 | |
| 
 | |
| 	"github.com/stretchr/testify/assert"
 | |
| )
 | |
| 
 | |
| func doCheckRepositoryEmptyStatus(ctx APITestContext, isEmpty bool) func(*testing.T) {
 | |
| 	return doAPIGetRepository(ctx, func(t *testing.T, repository api.Repository) {
 | |
| 		assert.Equal(t, isEmpty, repository.Empty)
 | |
| 	})
 | |
| }
 | |
| 
 | |
| func doAddChangesToCheckout(dstPath, filename string) func(*testing.T) {
 | |
| 	return func(t *testing.T) {
 | |
| 		assert.NoError(t, ioutil.WriteFile(filepath.Join(dstPath, filename), []byte(fmt.Sprintf("# Testing Repository\n\nOriginally created in: %s at time: %v", dstPath, time.Now())), 0644))
 | |
| 		assert.NoError(t, git.AddChanges(dstPath, true))
 | |
| 		signature := git.Signature{
 | |
| 			Email: "test@example.com",
 | |
| 			Name:  "test",
 | |
| 			When:  time.Now(),
 | |
| 		}
 | |
| 		assert.NoError(t, git.CommitChanges(dstPath, git.CommitChangesOptions{
 | |
| 			Committer: &signature,
 | |
| 			Author:    &signature,
 | |
| 			Message:   "Initial Commit",
 | |
| 		}))
 | |
| 	}
 | |
| }
 | |
| 
 | |
| func TestPushDeployKeyOnEmptyRepo(t *testing.T) {
 | |
| 	onGiteaRun(t, testPushDeployKeyOnEmptyRepo)
 | |
| }
 | |
| 
 | |
| func testPushDeployKeyOnEmptyRepo(t *testing.T, u *url.URL) {
 | |
| 	// OK login
 | |
| 	ctx := NewAPITestContext(t, "user2", "deploy-key-empty-repo-1")
 | |
| 	keyname := fmt.Sprintf("%s-push", ctx.Reponame)
 | |
| 	u.Path = ctx.GitPath()
 | |
| 
 | |
| 	t.Run("CreateEmptyRepository", doAPICreateRepository(ctx, true))
 | |
| 
 | |
| 	t.Run("CheckIsEmpty", doCheckRepositoryEmptyStatus(ctx, true))
 | |
| 
 | |
| 	withKeyFile(t, keyname, func(keyFile string) {
 | |
| 		t.Run("CreatePushDeployKey", doAPICreateDeployKey(ctx, keyname, keyFile, false))
 | |
| 
 | |
| 		// Setup the testing repository
 | |
| 		dstPath, err := ioutil.TempDir("", "repo-tmp-deploy-key-empty-repo-1")
 | |
| 		assert.NoError(t, err)
 | |
| 		defer os.RemoveAll(dstPath)
 | |
| 
 | |
| 		t.Run("InitTestRepository", doGitInitTestRepository(dstPath))
 | |
| 
 | |
| 		//Setup remote link
 | |
| 		sshURL := createSSHUrl(ctx.GitPath(), u)
 | |
| 
 | |
| 		t.Run("AddRemote", doGitAddRemote(dstPath, "origin", sshURL))
 | |
| 
 | |
| 		t.Run("SSHPushTestRepository", doGitPushTestRepository(dstPath, "origin", "master"))
 | |
| 
 | |
| 		t.Run("CheckIsNotEmpty", doCheckRepositoryEmptyStatus(ctx, false))
 | |
| 
 | |
| 		t.Run("DeleteRepository", doAPIDeleteRepository(ctx))
 | |
| 	})
 | |
| }
 | |
| 
 | |
| func TestKeyOnlyOneType(t *testing.T) {
 | |
| 	onGiteaRun(t, testKeyOnlyOneType)
 | |
| }
 | |
| 
 | |
| func testKeyOnlyOneType(t *testing.T, u *url.URL) {
 | |
| 	// Once a key is a user key we cannot use it as a deploy key
 | |
| 	// If we delete it from the user we should be able to use it as a deploy key
 | |
| 	reponame := "ssh-key-test-repo"
 | |
| 	username := "user2"
 | |
| 	u.Path = fmt.Sprintf("%s/%s.git", username, reponame)
 | |
| 	keyname := fmt.Sprintf("%s-push", reponame)
 | |
| 
 | |
| 	// OK login
 | |
| 	ctx := NewAPITestContext(t, username, reponame)
 | |
| 
 | |
| 	otherCtx := ctx
 | |
| 	otherCtx.Reponame = "ssh-key-test-repo-2"
 | |
| 
 | |
| 	failCtx := ctx
 | |
| 	failCtx.ExpectedCode = http.StatusUnprocessableEntity
 | |
| 
 | |
| 	t.Run("CreateRepository", doAPICreateRepository(ctx, false))
 | |
| 	t.Run("CreateOtherRepository", doAPICreateRepository(otherCtx, false))
 | |
| 
 | |
| 	withKeyFile(t, keyname, func(keyFile string) {
 | |
| 		var userKeyPublicKeyID int64
 | |
| 		t.Run("KeyCanOnlyBeUser", func(t *testing.T) {
 | |
| 			dstPath, err := ioutil.TempDir("", ctx.Reponame)
 | |
| 			assert.NoError(t, err)
 | |
| 			defer os.RemoveAll(dstPath)
 | |
| 
 | |
| 			sshURL := createSSHUrl(ctx.GitPath(), u)
 | |
| 
 | |
| 			t.Run("FailToClone", doGitCloneFail(sshURL))
 | |
| 
 | |
| 			t.Run("CreateUserKey", doAPICreateUserKey(ctx, keyname, keyFile, func(t *testing.T, publicKey api.PublicKey) {
 | |
| 				userKeyPublicKeyID = publicKey.ID
 | |
| 			}))
 | |
| 
 | |
| 			t.Run("FailToAddReadOnlyDeployKey", doAPICreateDeployKey(failCtx, keyname, keyFile, true))
 | |
| 
 | |
| 			t.Run("FailToAddDeployKey", doAPICreateDeployKey(failCtx, keyname, keyFile, false))
 | |
| 
 | |
| 			t.Run("Clone", doGitClone(dstPath, sshURL))
 | |
| 
 | |
| 			t.Run("AddChanges", doAddChangesToCheckout(dstPath, "CHANGES1.md"))
 | |
| 
 | |
| 			t.Run("Push", doGitPushTestRepository(dstPath, "origin", "master"))
 | |
| 
 | |
| 			t.Run("DeleteUserKey", doAPIDeleteUserKey(ctx, userKeyPublicKeyID))
 | |
| 		})
 | |
| 
 | |
| 		t.Run("KeyCanBeAnyDeployButNotUserAswell", func(t *testing.T) {
 | |
| 			dstPath, err := ioutil.TempDir("", ctx.Reponame)
 | |
| 			assert.NoError(t, err)
 | |
| 			defer os.RemoveAll(dstPath)
 | |
| 
 | |
| 			sshURL := createSSHUrl(ctx.GitPath(), u)
 | |
| 
 | |
| 			t.Run("FailToClone", doGitCloneFail(sshURL))
 | |
| 
 | |
| 			// Should now be able to add...
 | |
| 			t.Run("AddReadOnlyDeployKey", doAPICreateDeployKey(ctx, keyname, keyFile, true))
 | |
| 
 | |
| 			t.Run("Clone", doGitClone(dstPath, sshURL))
 | |
| 
 | |
| 			t.Run("AddChanges", doAddChangesToCheckout(dstPath, "CHANGES2.md"))
 | |
| 
 | |
| 			t.Run("FailToPush", doGitPushTestRepositoryFail(dstPath, "origin", "master"))
 | |
| 
 | |
| 			otherSSHURL := createSSHUrl(otherCtx.GitPath(), u)
 | |
| 			dstOtherPath, err := ioutil.TempDir("", otherCtx.Reponame)
 | |
| 			assert.NoError(t, err)
 | |
| 			defer os.RemoveAll(dstOtherPath)
 | |
| 
 | |
| 			t.Run("AddWriterDeployKeyToOther", doAPICreateDeployKey(otherCtx, keyname, keyFile, false))
 | |
| 
 | |
| 			t.Run("CloneOther", doGitClone(dstOtherPath, otherSSHURL))
 | |
| 
 | |
| 			t.Run("AddChangesToOther", doAddChangesToCheckout(dstOtherPath, "CHANGES3.md"))
 | |
| 
 | |
| 			t.Run("PushToOther", doGitPushTestRepository(dstOtherPath, "origin", "master"))
 | |
| 
 | |
| 			t.Run("FailToCreateUserKey", doAPICreateUserKey(failCtx, keyname, keyFile))
 | |
| 		})
 | |
| 
 | |
| 		t.Run("DeleteRepositoryShouldReleaseKey", func(t *testing.T) {
 | |
| 			otherSSHURL := createSSHUrl(otherCtx.GitPath(), u)
 | |
| 			dstOtherPath, err := ioutil.TempDir("", otherCtx.Reponame)
 | |
| 			assert.NoError(t, err)
 | |
| 			defer os.RemoveAll(dstOtherPath)
 | |
| 
 | |
| 			t.Run("DeleteRepository", doAPIDeleteRepository(ctx))
 | |
| 
 | |
| 			t.Run("FailToCreateUserKeyAsStillDeploy", doAPICreateUserKey(failCtx, keyname, keyFile))
 | |
| 
 | |
| 			t.Run("MakeSureCloneOtherStillWorks", doGitClone(dstOtherPath, otherSSHURL))
 | |
| 
 | |
| 			t.Run("AddChangesToOther", doAddChangesToCheckout(dstOtherPath, "CHANGES3.md"))
 | |
| 
 | |
| 			t.Run("PushToOther", doGitPushTestRepository(dstOtherPath, "origin", "master"))
 | |
| 
 | |
| 			t.Run("DeleteOtherRepository", doAPIDeleteRepository(otherCtx))
 | |
| 
 | |
| 			t.Run("RecreateRepository", doAPICreateRepository(ctx, false))
 | |
| 
 | |
| 			t.Run("CreateUserKey", doAPICreateUserKey(ctx, keyname, keyFile, func(t *testing.T, publicKey api.PublicKey) {
 | |
| 				userKeyPublicKeyID = publicKey.ID
 | |
| 			}))
 | |
| 
 | |
| 			dstPath, err := ioutil.TempDir("", ctx.Reponame)
 | |
| 			assert.NoError(t, err)
 | |
| 			defer os.RemoveAll(dstPath)
 | |
| 
 | |
| 			sshURL := createSSHUrl(ctx.GitPath(), u)
 | |
| 
 | |
| 			t.Run("Clone", doGitClone(dstPath, sshURL))
 | |
| 
 | |
| 			t.Run("AddChanges", doAddChangesToCheckout(dstPath, "CHANGES1.md"))
 | |
| 
 | |
| 			t.Run("Push", doGitPushTestRepository(dstPath, "origin", "master"))
 | |
| 		})
 | |
| 
 | |
| 		t.Run("DeleteUserKeyShouldRemoveAbilityToClone", func(t *testing.T) {
 | |
| 			sshURL := createSSHUrl(ctx.GitPath(), u)
 | |
| 
 | |
| 			t.Run("DeleteUserKey", doAPIDeleteUserKey(ctx, userKeyPublicKeyID))
 | |
| 
 | |
| 			t.Run("FailToClone", doGitCloneFail(sshURL))
 | |
| 		})
 | |
| 	})
 | |
| }
 |