31416a5f4e
* keep sure if assigneeIDs == nil -> do nothing
* fix #8872
* Revert "keep sure if assigneeIDs == nil -> do nothing"
-> go handle it itself preaty well
This reverts commit e72d94129c.
* clarity comparson
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
* simplify
* Update models/issue_assignees.go
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
* Update issue_assignees.go
* simplify more
* add --if oneAssignee != ""-- again
* Update models/issue_assignees.go
Co-Authored-By: guillep2k <18600385+guillep2k@users.noreply.github.com>
* CI.restart()
* Update issue_assignees.go
* add Test for GetUserIDsByNames
* add Test for MakeIDsFromAPIAssigneesToAdd
* fix test
82 lines
2.3 KiB
Go
82 lines
2.3 KiB
Go
// Copyright 2018 The Gitea Authors. All rights reserved.
|
|
// Use of this source code is governed by a MIT-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package models
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestUpdateAssignee(t *testing.T) {
|
|
assert.NoError(t, PrepareTestDatabase())
|
|
|
|
// Fake issue with assignees
|
|
issue, err := GetIssueWithAttrsByID(1)
|
|
assert.NoError(t, err)
|
|
|
|
// Assign multiple users
|
|
user2, err := GetUserByID(2)
|
|
assert.NoError(t, err)
|
|
_, _, err = issue.ToggleAssignee(&User{ID: 1}, user2.ID)
|
|
assert.NoError(t, err)
|
|
|
|
user3, err := GetUserByID(3)
|
|
assert.NoError(t, err)
|
|
_, _, err = issue.ToggleAssignee(&User{ID: 1}, user3.ID)
|
|
assert.NoError(t, err)
|
|
|
|
user1, err := GetUserByID(1) // This user is already assigned (see the definition in fixtures), so running UpdateAssignee should unassign him
|
|
assert.NoError(t, err)
|
|
_, _, err = issue.ToggleAssignee(&User{ID: 1}, user1.ID)
|
|
assert.NoError(t, err)
|
|
|
|
// Check if he got removed
|
|
isAssigned, err := IsUserAssignedToIssue(issue, user1)
|
|
assert.NoError(t, err)
|
|
assert.False(t, isAssigned)
|
|
|
|
// Check if they're all there
|
|
assignees, err := GetAssigneesByIssue(issue)
|
|
assert.NoError(t, err)
|
|
|
|
var expectedAssignees []*User
|
|
expectedAssignees = append(expectedAssignees, user2, user3)
|
|
|
|
for in, assignee := range assignees {
|
|
assert.Equal(t, assignee.ID, expectedAssignees[in].ID)
|
|
}
|
|
|
|
// Check if the user is assigned
|
|
isAssigned, err = IsUserAssignedToIssue(issue, user2)
|
|
assert.NoError(t, err)
|
|
assert.True(t, isAssigned)
|
|
|
|
// This user should not be assigned
|
|
isAssigned, err = IsUserAssignedToIssue(issue, &User{ID: 4})
|
|
assert.NoError(t, err)
|
|
assert.False(t, isAssigned)
|
|
}
|
|
|
|
func TestMakeIDsFromAPIAssigneesToAdd(t *testing.T) {
|
|
IDs, err := MakeIDsFromAPIAssigneesToAdd("", []string{""})
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, []int64{}, IDs)
|
|
|
|
IDs, err = MakeIDsFromAPIAssigneesToAdd("", []string{"none_existing_user"})
|
|
assert.Error(t, err)
|
|
|
|
IDs, err = MakeIDsFromAPIAssigneesToAdd("user1", []string{"user1"})
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, []int64{1}, IDs)
|
|
|
|
IDs, err = MakeIDsFromAPIAssigneesToAdd("user2", []string{""})
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, []int64{2}, IDs)
|
|
|
|
IDs, err = MakeIDsFromAPIAssigneesToAdd("", []string{"user1", "user2"})
|
|
assert.NoError(t, err)
|
|
assert.Equal(t, []int64{1, 2}, IDs)
|
|
}
|