TeaSpeak
/
TeaWeb
1
0
Fork 0
Code Issues 1 Pull Requests Activity

Fixed some granted value bugs within the PermissionEditor.tsx

canary
WolverinDEV 2020-06-28 14:40:30 +02:00
parent e84a4dcaf0
commit 4365e03dbe
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
shared/js/ui/modal/permission/PermissionEditor.tsx
View File

@ -274,6 +274,7 @@ const PermissionEntryRow = (props: {
const [ flagSkip, setFlagSkip ] = useState(props.value.flagSkip); const [ flagSkip, setFlagSkip ] = useState(props.value.flagSkip);
const [ granted, setGranted ] = useState(props.value.granted); const [ granted, setGranted ] = useState(props.value.granted);
const [ forceGrantedUpdate, setForceGrantedUpdate ] = useState(false);
const [ grantedEditing, setGrantedEditing ] = useState(false); const [ grantedEditing, setGrantedEditing ] = useState(false);
const [ grantedApplying, setGrantedApplying ] = useState(false); const [ grantedApplying, setGrantedApplying ] = useState(false);
@ -346,15 +347,17 @@ const PermissionEntryRow = (props: {
if(typeof granted === "undefined") if(typeof granted === "undefined")
return; return;
setForceGrantedUpdate(true);
props.events.fire("action_remove_permissions", { permissions: [{ name: props.permission, mode: "grant" }] }); props.events.fire("action_remove_permissions", { permissions: [{ name: props.permission, mode: "grant" }] });
} else { } else {
const numberValue = parseInt(newValue); const numberValue = parseInt(newValue);
if(isNaN(numberValue)) return; if(isNaN(numberValue)) return;
if(numberValue === granted) { if(numberValue === granted && !forceGrantedUpdate) {
/* no change */ /* no change */
return; return;
} }
setForceGrantedUpdate(true);
props.events.fire("action_set_permissions", { permissions: [{ name: props.permission, mode: "grant", value: numberValue }]}); props.events.fire("action_set_permissions", { permissions: [{ name: props.permission, mode: "grant", value: numberValue }]});
} }
}} onChange={() => {}} onKeyPress={e => e.key === "Enter" && e.currentTarget.blur()} />; }} onChange={() => {}} onKeyPress={e => e.key === "Enter" && e.currentTarget.blur()} />;
@ -368,6 +371,7 @@ const PermissionEntryRow = (props: {
if(event.target === "grant") { if(event.target === "grant") {
setGranted(event.defaultValue); setGranted(event.defaultValue);
setGrantedEditing(true); setGrantedEditing(true);
setForceGrantedUpdate(true);
} else { } else {
if(isBoolPermission && typeof value === "undefined") { if(isBoolPermission && typeof value === "undefined") {
setValue(event.defaultValue >= 1 ? 1 : 0); setValue(event.defaultValue >= 1 ? 1 : 0);