From 36f5668586b9b567aa603021cf701617e3346163 Mon Sep 17 00:00:00 2001 From: WolverinDEV Date: Tue, 12 Jan 2021 21:18:55 +0100 Subject: [PATCH] Fixed some video related bugs --- ChangeLog.md | 4 ++++ shared/js/connection/rtc/Connection.ts | 1 - shared/js/connection/rtc/SdpUtils.ts | 2 +- shared/js/ui/modal/video-source/Controller.tsx | 5 ++++- 4 files changed, 9 insertions(+), 3 deletions(-) diff --git a/ChangeLog.md b/ChangeLog.md index a736d917..8473444c 100644 --- a/ChangeLog.md +++ b/ChangeLog.md @@ -1,4 +1,8 @@ # Changelog: +* **12.01.21** + - Fixed bug where the quick video select popup did not start the video broadcasting + - Fixed a bug where an invalid H264 codec may caused video connection setup failure + * **09.01.21** - The connect modal now connects when pressing `Enter` on the address line diff --git a/shared/js/connection/rtc/Connection.ts b/shared/js/connection/rtc/Connection.ts index ed9775b2..5ff6f4fb 100644 --- a/shared/js/connection/rtc/Connection.ts +++ b/shared/js/connection/rtc/Connection.ts @@ -63,7 +63,6 @@ class RetryTimeCalculator { } calculateRetryTime() { - return 0; if(this.retryCount >= 5) { /* no more retries */ return 0; diff --git a/shared/js/connection/rtc/SdpUtils.ts b/shared/js/connection/rtc/SdpUtils.ts index aa3ae2a0..734ed817 100644 --- a/shared/js/connection/rtc/SdpUtils.ts +++ b/shared/js/connection/rtc/SdpUtils.ts @@ -57,7 +57,7 @@ export class SdpProcessor { fmtp: { "level-asymmetry-allowed": 1, "packetization-mode": 1, - "profile-level-id": "4d0028", + "profile-level-id": "42001f", "max-fr": 30, } }, diff --git a/shared/js/ui/modal/video-source/Controller.tsx b/shared/js/ui/modal/video-source/Controller.tsx index c9b37773..4d06f5c8 100644 --- a/shared/js/ui/modal/video-source/Controller.tsx +++ b/shared/js/ui/modal/video-source/Controller.tsx @@ -94,7 +94,10 @@ export async function spawnVideoSourceSelectModal(type: VideoBroadcastType, mode } if(event.status.status === "preview") { - /* we've successfully selected something */ + /* We've successfully selected something. Use that device instead. */ + result.source?.deref(); + result.source = controller.getCurrentSource()?.ref(); + result.config = controller.getBroadcastConstraints(); modal.destroy(); } });