TeaSpeak/TeaWeb
TeaSpeak/TeaWeb
1
0
Fork 0
Code Issues 1 Pull requests Activity

Fixed setState in constructor react warning

Browse source
This commit is contained in:
WolverinDEV 2020-05-23 10:47:59 +02:00
parent 93fd5af1b8
commit 00b0a40fd9
1 changed files with 15 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
shared/js/ui/tree/Client.tsx
View file

@ -255,8 +255,9 @@ interface ClientNameState {
@ReactEventHandler<ClientName>(e => e.props.client.events) @ReactEventHandler<ClientName>(e => e.props.client.events)
class ClientName extends ReactComponentBase<ClientNameProperties, ClientNameState> { class ClientName extends ReactComponentBase<ClientNameProperties, ClientNameState> {
protected initialize() { protected initialize() {
this.updateGroups(); this.state = {} as any;
this.updateAwayMessage(); this.updateGroups(this.state);
this.updateAwayMessage(this.state);
} }
protected defaultState(): ClientNameState { protected defaultState(): ClientNameState {
@ -273,7 +274,7 @@ class ClientName extends ReactComponentBase<ClientNameProperties, ClientNameStat
</div> </div>
} }
private updateGroups() { private updateGroups(state: ClientNameState) {
let prefix_groups: string[] = []; let prefix_groups: string[] = [];
let suffix_groups: string[] = []; let suffix_groups: string[] = [];
for(const group_id of this.props.client.assignedServerGroupIds()) { for(const group_id of this.props.client.assignedServerGroupIds()) {
@ -294,27 +295,27 @@ class ClientName extends ReactComponentBase<ClientNameProperties, ClientNameStat
suffix_groups.splice(0, 0, channel_group.name); suffix_groups.splice(0, 0, channel_group.name);
} }
this.setState({ state.group_prefix = suffix_groups.map(e => "[" + e + "]").join("");
group_suffix: suffix_groups.map(e => "[" + e + "]").join(""), state.group_suffix = prefix_groups.map(e => "[" + e + "]").join("");
group_prefix: prefix_groups.map(e => "[" + e + "]").join("")
});
} }
private updateAwayMessage() { private updateAwayMessage(state: ClientNameState) {
this.setState({ state.away_message = this.props.client.properties.client_away_message && " [" + this.props.client.properties.client_away_message + "]";
away_message: this.props.client.properties.client_away_message && " [" + this.props.client.properties.client_away_message + "]"
});
} }
@EventHandler<ClientEvents>("notify_properties_updated") @EventHandler<ClientEvents>("notify_properties_updated")
private handlePropertiesChanged(event: ClientEvents["notify_properties_updated"]) { private handlePropertiesChanged(event: ClientEvents["notify_properties_updated"]) {
const updatedState: ClientNameState = {} as any;
if(typeof event.updated_properties.client_away !== "undefined" || typeof event.updated_properties.client_away_message !== "undefined") { if(typeof event.updated_properties.client_away !== "undefined" || typeof event.updated_properties.client_away_message !== "undefined") {
this.updateAwayMessage(); this.updateAwayMessage(updatedState);
} }
if(typeof event.updated_properties.client_servergroups !== "undefined" || typeof event.updated_properties.client_channel_group_id !== "undefined") { if(typeof event.updated_properties.client_servergroups !== "undefined" || typeof event.updated_properties.client_channel_group_id !== "undefined") {
this.updateGroups(); this.updateGroups(updatedState);
} }
if(typeof event.updated_properties.client_nickname !== "undefined") {
if(Object.keys(updatedState).length > 0)
this.setState(updatedState);
else if(typeof event.updated_properties.client_nickname !== "undefined") {
this.forceUpdate(); this.forceUpdate();
} }
} }